Khalid (khalidz0r) wrote in lj_dev,
Khalid
khalidz0r
lj_dev

style=mine Issues

Lately, I have been trying to write patches that would give consistency and continuation for style=mine in both style systems. That is, if style=mine is set and you do some action, it should behave the same in both styles systems, and it should reserve style=mine when it is intuitive to do so.

This includes:



There is one case timwi seems to have written a patch for earlier that never got dealt with, which talks about respecting style=mine when previewing a comment, and another reported by crschmidt that talks about the inconsistency of style=mine among free and paid accounts. Those two cases, although related, defer from the above one in the fact that it's not an issue of preserving style=mine but starting it. They are, however, related.

There are more cases I have been thinking of:


  • When adding a memory, it would be a good idea to link back to the post. I do not know a good reason for it not to be done, and I think it should also preserve style=mine. I will write a patch for that in case it's just not there because nobody has found it worthwhile to do.

  • One other very important issue is that of permalinks, those are links that are available in comments and link to them. I have also included preserving them in one of the above patches, however, pinterface suggests that permalinks shouldn't have style=mine preservation. So what does everybody think is the right thing? The problem is that S2 uses the permalink url for collapsed threads, so if we are going to separate them, all S2 styles would have to be edited in order to include the style=mine preservation.



One more note, to keep the url format clean (style=mine at the end, for instance), I had to write a new version of talkargs that smartly puts anchors at the end. The bugs I mentioned above depend on it.

Finally, I want to ask, does anybody know of more cases where style=mine preservation currently fails?

So, opinions are welcome, and of course the word of those who have the power to decide would also be appreciated. Thanks!
Subscribe
  • Post a new comment

    Error

    Anonymous comments are disabled in this journal

    default userpic

    Your reply will be screened

    Your IP address will be recorded 

  • 9 comments