Khalid (khalidz0r) wrote in lj_dev,
Khalid
khalidz0r
lj_dev

A small thing about the login page

I hope I am posting in the correct place, and sorry if that's not the case.

I have noticed that when you log in through http://www.livejournal.com/login.bml, and get logged on, the message that appears says:

"To log in to LiveJournal.com, enter your username and password below. New Users: To create an account, go here."

While you are already logged on, and there is obviously no place to put your username and password below.

I have checked the code of this page from the CVS, and I believe that it is due to this part:


$body .= "<?h1 $ML{'.login.head'} h1?>";
$body .= "<?p " . BML::ml(".login.text1", {'sitename' => $LJ::SITENAME}) . "
p?>\n";
$body .= "<?p $ML{'.login.text2'} p?>\n";


Which should be something like:


$body .= "<?h1 $ML{'.login.head'} h1?>";
if ($remote) {
$body .= "<?p " . BML::ml(".login.text3", {'sitename' => $LJ::SITENAME}) . "
p?>\n";
} else {
$body .= "<?p " . BML::ml(".login.text1", {'sitename' => $LJ::SITENAME}) . "
p?>\n";
}
$body .= "<?p $ML{'.login.text2'} p?>\n";


Where text3 would contain a welcome message to LiveJournal.

I have never dealt with bml or perl, so I hope this isn't very far from the correct form.
Subscribe
  • Post a new comment

    Error

    Anonymous comments are disabled in this journal

    default userpic

    Your reply will be screened

    Your IP address will be recorded 

  • 3 comments