Martin Atkins (mart) wrote in lj_dev,
Martin Atkins
mart
lj_dev

S2 Styles Problem

It seems that whenever I edit a style from the advanced style editor, whichever style it is, the style is then “broken” and won't run, giving the error:

Error preparing to run: S2::run_code: Undefined function prop_init() (3 )

The styles I've not yet edited are fine, and this seems to happen no matter which layout is selected. It also appears to be irreversible at this time, so don't go ahead and try to recreate on your primary style or you might make your journal useless like I just did.

It's unlikely that prop_init() is actually going missing, or else this error would effect all styles and not just those that have been modified recently.


As I was starting to suspect, the style editor is no longer referencing the core layer when saving a style. Here's a style after I saved it:

+---------+--------+-------+
| styleid | type   | s2lid |
+---------+--------+-------+
|       3 | core   |     0 |
|       3 | i18nc  |     0 |
|       3 | layout |   300 |
|       3 | theme  |     0 |
|       3 | i18n   |     0 |
|       3 | user   |     0 |
+---------+--------+-------+

Notice that only the layout is being loaded. Since the layout I was using on my goathack account actually defines prop_init(), it crashes much later with the old error about trying to dereference an empty string.

The next thing to do is work out why the core layer is no longer being added. Once I've done that, I'll post a patch on Zilla.


Sorted. bug created and patch posted. Marked critical, since this breaks styles.

Subscribe
  • Post a new comment

    Error

    Anonymous comments are disabled in this journal

    default userpic

    Your reply will be screened

    Your IP address will be recorded 

  • 13 comments