Kevin M. Brooks (lucretio) wrote in lj_dev,
Kevin M. Brooks
lucretio
lj_dev

Consistent use of LJ::item_link

Since there is LJ::item_link, there shouldn't be any reference to the URL style anywhere else, should there?

I found these:
lucretio@goathack:~/htdocs$ grep 'id\.html' *.bml
editjournal_do.bml:             my $readurl = LJ::journal_base($ju) . "/$ditemid.html";
go.bml:         return BML::redirect(LJ::journal_base($u) . "/$jumpid.html");
talkmulti.bml:    my $commentlink = LJ::journal_base($u) . "/$ditemid.html";
talkpost.bml:        $readurl = "$ditemid.html";
talkpost_do.bml:    my $talkurl = LJ::journal_base($u) . "/$ditemid.html";
talkread.bml: my $talkurl = LJ::journal_base($u) . "/$ditemid.html";
talkread.bml:         return BML::redirect(LJ::journal_base($u) . "/$id.html");
talkread.bml:         my $readurl = LJ::journal_base($u) . "/$ditemid.html";
talkread.bml:     $posturl = "$ditemid.html?mode=reply" if $new_url;
talkscreen.bml: my $commentlink = LJ::journal_base($u) . "/$ditemid.html?view=$dtalkid#t$dtalkid";


Should these all use LJ::item_link?
Subscribe
  • Post a new comment

    Error

    Anonymous comments are disabled in this journal

    default userpic

    Your reply will be screened

    Your IP address will be recorded 

  • 2 comments