Alan Jaffray (alanj) wrote in lj_dev,
Alan Jaffray
alanj
lj_dev

  • Music:

Clarifying "reviewed"

The "reviewed" keyword does not mean "I looked it over, seems fine to me."

The "reviewed" keyword means "I understand the code being changed, I have closely read and understand the patch, I have installed this on my dev server and tested all code paths, I am confident that it works as stated, and Brad can punch me in the nose if he applies it and it doesn't work."

Thanks.
Subscribe
  • Post a new comment

    Error

    Anonymous comments are disabled in this journal

    default userpic

    Your reply will be screened

    Your IP address will be recorded 

  • 3 comments