Martin Atkins (mart) wrote in lj_dev,
Martin Atkins

New ‘patch’ keyword on Zilla

When you submit a patch to Zilla from now on, please tag the bug you're attaching it to with the ‘patch’ keyword. This allows those reviewing patches (and later committing them to CVS) to easily locate the bugs which people have been working on. Don't mark a bug as Resolved ‘FIXED’; This will be done by whoever puts the code in CVS, and will at that point remove that bug from the “patch waiting” list.

If you review a posted patch and find that it contains an error, post a comment explaining the error, and if you aren't going to post a revised patch remove the ‘patch’ keyword which the person who posts a revised patch can then re-add. However, only remove the ‘patch’ keyword if you're sure there is an error; that is, you tested the code or can see there's a definite syntax error. If you aren't going to do a full review, post a comment but note that you are not sure and leave the keyword intact so that someone else can easily give a second opinion.

If everyone follows these guidelines, we should hopefully be able to get patches into CVS more efficiently.

  • Post a new comment


    Anonymous comments are disabled in this journal

    default userpic

    Your reply will be screened

    Your IP address will be recorded