Martin Atkins (mart) wrote in lj_dev,
Martin Atkins
mart
lj_dev

Patch: Fix for translation/FAQ interaction

Currently, if a FAQ text is edited at severity 2, its title is also flagged as severity 2 even if it isn't changed at all. My pretty simple patch puts some checking in to see what has changed.

A more robust solution would have been to pull the text from the database again to compare, but I figured that FAQs can only be updated by a select few people, and these people are unlikely to screw with the form fields before submitting since it'd only cause weirdness and presumably these volunteers are doing FAQ editing because they want the FAQs to be good and accurate, or something.

I would like to have tested this, but I gave up trying to figure out how to hook the FAQ system into the translation system, so it's not been tested. The patch is simple enough that I'm submitting it anyway, since anyone can see what it's doing just by looking at it.

Subscribe
  • Post a new comment

    Error

    Anonymous comments are disabled in this journal

    default userpic

    Your reply will be screened

    Your IP address will be recorded 

  • 0 comments