Gavin (halkeye) wrote in lj_dev,
Gavin
halkeye
lj_dev

Support System Override Viewer

Next up we have a tool for the customization support people. It adds another row (as well as fixes a style issue todo with see_request) listing weither or not the user has overrides, and if they do, it has a link to a new page showing the overrides.
If the user is a paid member, then the support team must have privs.

I've address the issue with privacy (somewhat), and elimited the userid and replaced with just user.

The only code i'm not liking, at least for readability is:

+ if ( LJ::get_cap($u, "paid") || LJ::get_cap($u, "perm") ) {
+ return LJ::bad_input("You need supportpriv to see the overrides of paid members") unless (
+ LJ::check_priv($dbs, $remote, "supporthelp", "customization") ||
+ LJ::check_priv($dbs, $remote, "supporthelp") );
+ }

So if someone could suggest something better, let me know.

I got the customization people to test things, and they claim everthing is working (as per 24153883)

Patched files:
livejournal/htdocs/support/see_request

Created files:
livejournal/htdocs/styles/browse/override.bml

Patches:
overrides.bml.diff
Subscribe
  • Post a new comment

    Error

    Anonymous comments are disabled in this journal

    default userpic

    Your reply will be screened

    Your IP address will be recorded 

  • 6 comments