Evan Martin (evan) wrote in lj_dev,
Evan Martin

a note about untested patches

When a patch is submitted that is untested, what to you expect Brad to do? Put it on the live site and see if it works?

I don't think it'll happen. :)

WRT that interests patch, since you made the max interests number editable you could set it down to a number like three and then create the interests manually to test it, or (as Brad usually does to test load-related patches) write some Perl scripts to automatically stuff a few thousand interests into your database.

But really, a patch is no good unless it's guaranteed to work, and even in that case we have to carefully review the code before it's allowed on the site. Anything less can be better presented as a description; ie., "Add a variable to ljconfig.pl and change the max interest count in {x,y}.bml to use that variable," because Brad can do that himself just as efficiently as he can read through a patch and make sure it works.

Please, don't take this as a personal attack. Patches are most welcome, but we're trying to cut down on Brad's workload if at all possible. :)

  • Post a new comment


    Anonymous comments are disabled in this journal

    default userpic

    Your reply will be screened

    Your IP address will be recorded