Evan Martin (evan) wrote in lj_dev,
Evan Martin
evan
lj_dev

Patch: fix the headings on the talk* pages.

These pages use the <lj user="...">-style formatting, but they use the person's "full name" (not their username) for the link text. This gets really confusing if someone sets their full name to someone else's username-- then, they can almost "forge" their identity as someone else...

The patch:
- headings now include both username and full name.
- removed the bold tag that was applied across all of the text which actually only bolded one (inconsequential) word.
- fixed the BML tag for communities so they use the /community/ URL instead of /users/.
- use that BML tag for posting in communities.
- we were using LJ::ehtml instead of BML::eall on the talkpost page, while we were using the BML one on talkread. Bad form!

Normal post:
http://goathack.livejournal.org:8012/talkpost.bml?itemid=1

Community post:
http://goathack.livejournal.org:8012/talkread.bml?itemid=3

How this handles the forgery:
http://goathack.livejournal.org:8012/talkpost.bml?itemid=4

The patch:
http://goathack.livejournal.org:8012/patches/2002-01-15-talkheading.patch
Subscribe
  • Post a new comment

    Error

    Anonymous comments are disabled in this journal

    default userpic

    Your reply will be screened

    Your IP address will be recorded 

  • 10 comments