September 13th, 2002

  • alanj

Clarifying "reviewed"

The "reviewed" keyword does not mean "I looked it over, seems fine to me."

The "reviewed" keyword means "I understand the code being changed, I have closely read and understand the patch, I have installed this on my dev server and tested all code paths, I am confident that it works as stated, and Brad can punch me in the nose if he applies it and it doesn't work."

  • Current Music
    DELTRON 3030 - Positive Contact