?

Log in

No account? Create an account
August 13th, 2002 - LiveJournal Development — LiveJournal [entries|archive|friends|userinfo]
LiveJournal Development

[ userinfo | livejournal userinfo ]
[ archive | journal archive ]

August 13th, 2002

Check in? [Aug. 13th, 2002|12:43 pm]
LiveJournal Development

lj_dev

[timwi]
Does anyone of you know why these patches aren't being committed? I always thought Brad wanted this so badly.
link11 comments|post comment

New ‘patch’ keyword on Zilla [Aug. 13th, 2002|06:09 pm]
LiveJournal Development

lj_dev

[mart]

When you submit a patch to Zilla from now on, please tag the bug you're attaching it to with the ‘patch’ keyword. This allows those reviewing patches (and later committing them to CVS) to easily locate the bugs which people have been working on. Don't mark a bug as Resolved ‘FIXED’; This will be done by whoever puts the code in CVS, and will at that point remove that bug from the “patch waiting” list.

If you review a posted patch and find that it contains an error, post a comment explaining the error, and if you aren't going to post a revised patch remove the ‘patch’ keyword which the person who posts a revised patch can then re-add. However, only remove the ‘patch’ keyword if you're sure there is an error; that is, you tested the code or can see there's a definite syntax error. If you aren't going to do a full review, post a comment but note that you are not sure and leave the keyword intact so that someone else can easily give a second opinion.

If everyone follows these guidelines, we should hopefully be able to get patches into CVS more efficiently.

link3 comments|post comment

navigation
[ viewing | August 13th, 2002 ]
[ go | Previous Day|Next Day ]