Log in

No account? Create an account
LiveJournal Development [entries|archive|friends|userinfo]
LiveJournal Development

[ userinfo | livejournal userinfo ]
[ archive | journal archive ]

June 20th, 2002

(no subject) [Jun. 20th, 2002|01:06 pm]
LiveJournal Development

I decided I'd have a try at creating a patch based on my suggestion. Its available at http://www.andrewheadley.barrysworld.net/diff.txt. Appologies if this is in the wrong format, and is untested.

Edit: (1834 UK Time) Updated the diff file to remove the HTML in all the erros in that section
link11 comments|post comment

Patch: Fix for translation/FAQ interaction [Jun. 20th, 2002|02:57 pm]
LiveJournal Development



Currently, if a FAQ text is edited at severity 2, its title is also flagged as severity 2 even if it isn't changed at all. My pretty simple patch puts some checking in to see what has changed.

A more robust solution would have been to pull the text from the database again to compare, but I figured that FAQs can only be updated by a select few people, and these people are unlikely to screw with the form fields before submitting since it'd only cause weirdness and presumably these volunteers are doing FAQ editing because they want the FAQs to be good and accurate, or something.

I would like to have tested this, but I gave up trying to figure out how to hook the FAQ system into the translation system, so it's not been tested. The patch is simple enough that I'm submitting it anyway, since anyone can see what it's doing just by looking at it.

linkpost comment

[ viewing | June 20th, 2002 ]
[ go | Previous Day|Next Day ]