?

Log in

No account? Create an account
May 18th, 2002 - LiveJournal Development — LiveJournal [entries|archive|friends|userinfo]
LiveJournal Development

[ userinfo | livejournal userinfo ]
[ archive | journal archive ]

May 18th, 2002

[PATCHES] clean up directory searches, fix some bugs [May. 18th, 2002|03:25 am]
LiveJournal Development

lj_dev

[lucretio]
[mood |accomplished]

Patch for: /community/search.bml

Bug report: here

What the patch does:
  • makes valid XHTML 1.0 Transitional
  • removes superfluous checkboxes
  • makes /community/search.bml more like directorysearch.bml
Test: here

Patch: 2002-05-18-comm-search.bml.diff



Patch for: directorysearch.bml

What the patch does:
  • makes valid XHTML 1.0 Transitional
  • adds a criterion ("Only communities")
  • adds an Output Format ("Community View")
This patch basically makes /community/search.bml unnecessary.

Test: here

Patch: 2002-05-18-directorysearch.bml.diff

...

Update: Should I have used html_select(), html_text(), and html_check() on these?
linkpost comment

Patch: /ljcom/htdocs/download/index.bml [May. 18th, 2002|04:41 pm]
LiveJournal Development
lj_dev
[xenofalcon]
Update: May 30. Wow. Okay, from now on I won't submit a patch that hasn't been tested. This one is broken. I'm working on fixing it, and I'll make a new post when I've double-checked this. Damn, I feel like a newbie.
Update: May 22. Removed mention of Semagic client not being available for download due to recent events, added second author of KLuJe.

This patch is a general update to the client download page. It adds a small amount of additional client information (including two new clients and a platform to go along with them), and reformats the code to a more human-readable format. Due to the reformatting, the diff is rather painful to look at, so I have included a link to the new file as well. Many thanks to opiummmm for his pointers with this.

This patch has not been tested, but I have gone through it visually with a fine-toothed comb and a nice syntax highlighting program. If a kind soul with a goathack account could try patching their local version of this and commenting to this thread, I would be most grateful.

(Links are now broken, as the patch sucked)


In depth review of the changes made...Collapse )
link7 comments|post comment

navigation
[ viewing | May 18th, 2002 ]
[ go | Previous Day|Next Day ]