April 11th, 2002

Morgan Webb 2

Patches to see_request.bml v1.20 and supportlib.pl v1.19

Let's try this one more (re: http://www.livejournal.com/talkread.bml?journal=lj_dev&itemid=299888 & http://www.livejournal.com/talkread.bml?itemid=20552316) ... made additional modifications to the patch so that it's cleaner than before (and some recommendationed changes to patch from bradfitz).

I would like to request the following patch be applied to /support/see_request.bml so that support volunteers can see additional information with regards to the status of the request: For example:

Status: open (still waiting for approved answers) --> no answer submitted
Status: open (answered, but still needs help) --> answered but user needs more help (similar to help.bml)
Status: open (answered, awaiting closure) --> answer submitted.

You can find the diff at http://www.callete.com/~highway/see_request_121.diff
http://lj.teencity.org/support/see_request.bml?id=5 (example of answered request)
http://lj.teencity.org/support/see_request.bml?id=6 (example of non-answered request)

This will work with the additional patch to /cgi-bin/supportlib.pl where the verbiage will be stored instead of clogging see_request.bml. /support/see_request.bml calls a function in supportlib.pl, which returns a hash, a hash that contains the needed verbiage which is appended to $state in /support/see_request.bml

You can find the diff at http://www.callete.com/~highway/supportlib_120.diff
  • nslu

patch: adding target in links to comment in emails

currently, when you receive email saying that somebody replied to your post/comment, it has link to comment, which looks like http://www.livejournal.com/talkread.bml?journal=lj_dev&itemid=358970 and you have to scroll through comments to find particular one, which may be collapsed, if threading mode is on.
patch makes link look like http://www.livejournal.com/talkread.bml?journal=lj_dev&itemid=358970&view=3253562#t3253562
which is the same link 'you can view it here' you get when you post your comment.
also, patch is essential for implementation of my email-gate project.

upd: avva pointed that 'view=' method does not respect page breaks for long discussions; updated patch using 'thread=' is here
Collapse )