?

Log in

No account? Create an account
January 9th, 2002 - LiveJournal Development — LiveJournal [entries|archive|friends|userinfo]
LiveJournal Development

[ userinfo | livejournal userinfo ]
[ archive | journal archive ]

January 9th, 2002

PATCHES: Escape bml [Jan. 9th, 2002|03:49 am]
LiveJournal Development

lj_dev

[lucretio]
Note: These links no longer work. I think I messed up my goathack, so I wiped the whole thing clean, started fresh. This one should work: http://goathack.livejournal.org:8030/patches/2002-01-10-escapebml_no1.patch

According to this comment to my last patch, talkread.bml isn't escaping bml in comment subjects.

This patch does this. (Tested; works.)
http://goathack.livejournal.org:8030/patches/2001-01-09-talkread.bml.diff


I also noticed that userpic alt tags were cleaned for html. This led me to ask myself if they should be cleaned for bml as well. (I ended up doing this.)

On my goathack I put in a picture keyword of '(=H1 blah H1=)'. In editpics.bml, the keyword shows up as '<P><span class="heading">blah</span>' (because html was escaped). In allpics.bml, it came out unescaped.

#1. editpics.bml (tested; works):
http://goathack.livejournal.org:8030/patches/2001-01-09-editpics.bml.diff
#2. allpics.bml (tested; works):
http://goathack.livejournal.org:8030/patches/2001-01-09-allpics.bml.diff

I'm sure there are other places where bml should be escaped (topics? friends groups?). I'll check around later.

Found one more: when editing this entry using editjournal_do.bml, I noticed that the bml wasn't escaped, thus causing unwanted html to end up in the post. (I also escaped bml in friend group names and the picture selector.)
http://goathack.livejournal.org:8030/patches/2001-01-09-editjournal_do.bml.diff

Another (picture related): update.bml?mode=full doesn't escape bml in the picture selector (and friends groups). (Same with editjournal_do.bml. I went back and did this.)
http://goathack.livejournal.org:8030/patches/2001-01-09-update.bml.diff

Update: I believe this is driving me insane. "I can't go to bed because I just thought of another place I need to escape bml!" Argh. I'm going to bed anyway.

To-do: friends/editgroups.bml, friends/filter.bml

haha: The patches have the wrong year on them. I'm dumb.
link7 comments|post comment

Goathack move [Jan. 9th, 2002|06:43 pm]
LiveJournal Development

lj_dev

[bradfitz]
Goathack's going down and switching IP addresses. We just got informed that we have to move it out of Speakeasy in the next hour or so. We just never got around to moving it to InterNAP. :-)

I'll update DNS once it's moved. Sorry for the short notice. Take a break of hackin' LJ. :-)
link4 comments|post comment

Read-only -- please? [Jan. 9th, 2002|11:31 pm]
LiveJournal Development

lj_dev

[bradfitz]
Goathack's new IP is 66.150.15.142. DNS is updated but you may not be seeing the new address yet.

Please.... can somebody do the $LJ::READONLY stuff?

The time is fast approaching when we'll need that I haven't had time to start on it. It's not even critical that you get everywhere... the $dbh (master handle) won't have permission to do any writes, so even if the code allows it, it'll just fail. Some of the code will then show the error message, other places will just act like it worked (sadly).

So the important part is that you just insert warnings and messages in the 95% most common places... posting entries and posting comments, mainly. Use the "clientmessage" also to tell people they're in read-only mode. Return error messages on post, so their client doesn't eat their entry, etc.

This shouldn't take long to do and might even be kinda fun?
link1 comment|post comment

navigation
[ viewing | January 9th, 2002 ]
[ go | Previous Day|Next Day ]